[
https://issues.apache.org/jira/browse/YARN-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701893#comment-14701893
]
Li Lu commented on YARN-3814:
-----------------------------
Hi [~varun_saxena], thanks for the patch! I think the patch is mostly good,
only with a few nits:
- In TimelineReaderManager
- Configuration and YarnConfiguration appears to be unused.
- callerUGI is not used and not documented. What's our plan on that? How to
set caller UGI for now?
- In TimelineReaderWebServices,
- Can we have two constants for default delimiters? Right now we're spreading
them in the source code like:
{code}
parseKeyStrValuesStr(relatesTo, ",", ":"),
parseKeyStrValuesStr(isRelatedTo, ",", ":"),
parseKeyStrValueObj(infofilters, ",", ":"),
parseKeyStrValueStr(conffilters, ",", ":"),
parseValuesStr(metricfilters, ","), parseValuesStr(eventfilters, ","),
parseFieldsStr(fields, ","), callerUGI);
{code}
Similar problem also happens on line 280 after patch.
> REST API implementation for getting raw entities in TimelineReader
> ------------------------------------------------------------------
>
> Key: YARN-3814
> URL: https://issues.apache.org/jira/browse/YARN-3814
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-3814-YARN-2928.01.patch,
> YARN-3814-YARN-2928.02.patch, YARN-3814-YARN-2928.03.patch,
> YARN-3814-YARN-2928.04.patch, YARN-3814-YARN-2928.05.patch,
> YARN-3814.reference.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
