[ https://issues.apache.org/jira/browse/YARN-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707544#comment-14707544 ]
Hudson commented on YARN-3986: ------------------------------ SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2240 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2240/]) YARN-3986. getTransferredContainers in AbstractYarnScheduler should be present in YarnScheduler interface (rohithsharmaks: rev 22de7c1dca1be63d523de833163ae51bfe638a79) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/YarnScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java > getTransferredContainers in AbstractYarnScheduler should be present in > YarnScheduler interface instead > ------------------------------------------------------------------------------------------------------ > > Key: YARN-3986 > URL: https://issues.apache.org/jira/browse/YARN-3986 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Fix For: 2.8.0 > > Attachments: YARN-3986.01.patch, YARN-3986.02.patch, > YARN-3986.03.patch > > > Currently getTransferredContainers is present in {{AbstractYarnScheduler}}. > *But in ApplicationMasterService, while registering AM, we are calling this > method by typecasting it to AbstractYarnScheduler, which is incorrect.* > This method should be moved to YarnScheduler. > Because if a custom scheduler is to be added, it will implement > YarnScheduler, not AbstractYarnScheduler. > As ApplicationMasterService is calling getTransferredContainers by > typecasting it to AbstractYarnScheduler, it is imposing an indirect > dependency on AbstractYarnScheduler for any pluggable custom scheduler. > We can move the method to YarnScheduler and leave the definition in > AbstractYarnScheduler as it is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)