[
https://issues.apache.org/jira/browse/YARN-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711024#comment-14711024
]
Naganarasimha G R commented on YARN-4078:
-----------------------------------------
Yes [~rohithsharma] & [~varun_saxena], In most of the places its handled and
except in these 2 places its type casted ( but in AppInfo is unguarded). But
the point is why need to even have guarded check cant we expose both the
methods ({{getPendingResourceRequestForAttempt}} & {{getApplicationAttempt}}
) in {{YarnScheduler}} ?
> Unchecked typecast to AbstractYarnScheduler in AppInfo
> ------------------------------------------------------
>
> Key: YARN-4078
> URL: https://issues.apache.org/jira/browse/YARN-4078
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
>
> Currently getPendingResourceRequestForAttempt is present in
> {{AbstractYarnScheduler}}.
> *But in AppInfo, we are calling this method by typecasting it to
> AbstractYarnScheduler, which is incorrect.*
> Because if a custom scheduler is to be added, it will implement
> YarnScheduler, not AbstractYarnScheduler.
> This method should be moved to YarnScheduler or it should have a guarded
> check like in other places (RMAppAttemptBlock.getBlackListedNodes)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
