Li Lu commented on YARN-4074:

Thank [~sjlee0]! I looked at the current POC patch and have some comments:
# In general, I'm OK with this approach. I think the current FlowEntity design 
should provide sufficient information for the web UI POC. 
# As a general question, since we're returning our timeline entities as jsons 
in our web service, we need to some sort "rebuild" those entities on the js 
client side, right? If this is the case, we need to provide some js object 
model to be consistent with our TimelineEntity object model? I'm not a 
front-end expert  so I'd like to learn the typical practice on this problem. 
# Please make sure, in the final patch, to change timeline schema creator so 
that we're consistent with the list of tables. Maybe we'd like to find some 
better ways to keep all these tables consistent within writer, reader and 
schema creator in future. 
# I agree with all of you guys that we may want to refactor the current 
implementation. For example, we may not want to dispatch incoming timeline 
entity to different tables by a list of if-statements (deciding which table to 
go has already caused me some confusion when working on the offline aggregator 
patch rebase)? Also, the parsing logic can also be easily isolated I believe? 
# Some changes in files like FlowActivityRowKey.java are not included in this 

> [timeline reader] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>                 Key: YARN-4074
>                 URL: https://issues.apache.org/jira/browse/YARN-4074
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-4074-YARN-2928.POC.001.patch, 
> YARN-4074-YARN-2928.POC.002.patch
> Implement support for querying for flows and flow runs.
> We should be able to query for the most recent N flows, etc.
> This includes changes to the {{TimelineReader}} API if necessary, as well as 
> implementation of the API.

This message was sent by Atlassian JIRA

Reply via email to