[
https://issues.apache.org/jira/browse/YARN-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738144#comment-14738144
]
Rohith Sharma K S commented on YARN-4141:
-----------------------------------------
Thanks [~sunilg] for the patch..
nit :
# UpdateApplicationPriorityResponse can be created once and used. Now, 2 times
repsonse object is created separately.
{code}
+ UpdateApplicationPriorityResponse response = recordFactory
+ .newRecordInstance(UpdateApplicationPriorityResponse.class);
+ return response;
{code}
# Audit logger is logged as failure. I feel log level would be Success instead
of failure. Any thoughts?
{noformat}
RMAuditLogger.logFailure(
+ callerUGI.getShortUserName(),
+ AuditConstants.UPDATE_APP_PRIORITY,
+ "UNKNOWN",
+ "ClientRMService",
+ "Skip update application priority, as app is in "
+ + application.getState());
{noformat}
> Runtime Application Priority change should not throw exception for
> applications at finishing states
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-4141
> URL: https://issues.apache.org/jira/browse/YARN-4141
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: 0001-YARN-4141.patch
>
>
> As suggested by [~jlowe] in
> [MAPREDUCE-5870-comment|https://issues.apache.org/jira/browse/MAPREDUCE-5870?focusedCommentId=14737035&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14737035]
> , its good that if YARN can suppress exceptions during change application
> priority calls for applications at its finishing stages.
> Currently it will be difficult for clients to handle this. This will be
> similar to kill application behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
