[ 
https://issues.apache.org/jira/browse/YARN-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746194#comment-14746194
 ] 

Jason Lowe commented on YARN-4141:
----------------------------------

It looks like the latest patch will still throw an exception if the app is in 
the FINAL_SAVING state.  So if an app just unregistered and is trying to store 
the final state I think the patch will still throw an exception when trying to 
change the priority.  Rather than checking if the app final state is stored, 
would it make more sense to explicitly check for the app state in the enum set 
of  FINAL_SAVING,  FINISHING,  FINISHED,  FAILED,  KILLING, or  KILLED states 
and silently skip priority setting for those states?

Nit: "state cannot be update priority" should be "state cannot update priority"


> Runtime Application Priority change should not throw exception for 
> applications at finishing states
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4141
>                 URL: https://issues.apache.org/jira/browse/YARN-4141
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4141.patch, 0002-YARN-4141.patch, 
> 0003-YARN-4141.patch
>
>
> As suggested by [~jlowe] in 
> [MAPREDUCE-5870-comment|https://issues.apache.org/jira/browse/MAPREDUCE-5870?focusedCommentId=14737035&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14737035]
>  , its good that if YARN can suppress exceptions during change application 
> priority calls for applications at its finishing stages.
> Currently it will be difficult for clients to handle this. This will be 
> similar to kill application behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to