[ https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746171#comment-14746171 ]
Hudson commented on YARN-4158: ------------------------------ FAILURE: Integrated in Hadoop-trunk-Commit #8458 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8458/]) YARN-4158. Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers. Contributed by Zhihai Xu (jlowe: rev 8c1cdb17a03fec91bfab172fe92b67bdeb9ebfba) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java > Remove duplicate close for LogWriter in > AppLogAggregatorImpl#uploadLogsForContainers > ------------------------------------------------------------------------------------ > > Key: YARN-4158 > URL: https://issues.apache.org/jira/browse/YARN-4158 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Minor > Labels: cleanup > Fix For: 2.7.2 > > Attachments: YARN-4158.000.patch > > > Remove duplicate {{close}} for {{LogWriter}} in > {{AppLogAggregatorImpl#uploadLogsForContainers}} > {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is > called at the middle of the function and the other one is called at finally > block. It will be better to just close {{writer}} once. Also {{LogWriter}} > didn't implement java.io.Closeable interface. So we can't suppose > {{LogWriter.close}} is idempotent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)