[
https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746416#comment-14746416
]
Hudson commented on YARN-4158:
------------------------------
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #397 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/397/])
YARN-4158. Remove duplicate close for LogWriter in
AppLogAggregatorImpl#uploadLogsForContainers. Contributed by Zhihai Xu (jlowe:
rev 8c1cdb17a03fec91bfab172fe92b67bdeb9ebfba)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
* hadoop-yarn-project/CHANGES.txt
> Remove duplicate close for LogWriter in
> AppLogAggregatorImpl#uploadLogsForContainers
> ------------------------------------------------------------------------------------
>
> Key: YARN-4158
> URL: https://issues.apache.org/jira/browse/YARN-4158
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Minor
> Labels: cleanup
> Fix For: 2.7.2
>
> Attachments: YARN-4158.000.patch
>
>
> Remove duplicate {{close}} for {{LogWriter}} in
> {{AppLogAggregatorImpl#uploadLogsForContainers}}
> {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is
> called at the middle of the function and the other one is called at finally
> block. It will be better to just close {{writer}} once. Also {{LogWriter}}
> didn't implement java.io.Closeable interface. So we can't suppose
> {{LogWriter.close}} is idempotent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
