Jason Lowe commented on YARN-4141:

Thanks for updating the patch.  One last nit: the EnumSets were using are all 
effectively constants, and we should precompute these as static variable 
constants rather than create them every time.  Otherwise latest patch looks 
good to me.

> Runtime Application Priority change should not throw exception for 
> applications at finishing states
> ---------------------------------------------------------------------------------------------------
>                 Key: YARN-4141
>                 URL: https://issues.apache.org/jira/browse/YARN-4141
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4141.patch, 0002-YARN-4141.patch, 
> 0003-YARN-4141.patch, 0004-YARN-4141.patch
> As suggested by [~jlowe] in 
> [MAPREDUCE-5870-comment|https://issues.apache.org/jira/browse/MAPREDUCE-5870?focusedCommentId=14737035&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14737035]
>  , its good that if YARN can suppress exceptions during change application 
> priority calls for applications at its finishing stages.
> Currently it will be difficult for clients to handle this. This will be 
> similar to kill application behavior.

This message was sent by Atlassian JIRA

Reply via email to