[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906407#comment-14906407
]
Varun Saxena commented on YARN-4075:
------------------------------------
[~vrushalic], thanks for the review.
bq. Some of the path/query params are in sentence case and some are in all
lower case. I think it becomes hard to remember which ones are in which case as
we keep adding more REST endpoints, so my suggestion would be to keep all lower
case or all sentence case.
Thats a good point. Lets change it to lowercase. Will update a patch
bq. Are we encoding/decoding the URL path/query parameters in rest client
somewhere?
No. The responsibility of this lies with the client. They should properly
encode the URL as per specification otherwise the results may be incorrect. We
can probably document this.
bq. Hmm. If this rest service is running outside of a hadoop cluster, wondering
what is the default cluster id? I would think we can set it in a config for
this rest service, is that the idea..
Yes default cluster can be configured. But will REST service be running outside
of cluster ?
bq. Also, we now have a TestFlowDataGenerator class which generates test data
for flows. So we can use that the next time in the test cases
Ok...
> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
> Key: YARN-4075
> URL: https://issues.apache.org/jira/browse/YARN-4075
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: YARN-4075-YARN-2928.03.patch,
> YARN-4075-YARN-2928.04.patch, YARN-4075-YARN-2928.POC.1.patch,
> YARN-4075-YARN-2928.POC.2.patch
>
>
> We need to be able to query for flows and flow runs via REST.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
