[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905454#comment-14905454
]
Vrushali C commented on YARN-4075:
----------------------------------
Thanks Varun! It look good.
In TimelineReaderWebServices.java
lines 223 - 242:
Some of the path/query params are in sentence case and some are in all lower
case. I think it becomes hard to remember which ones are in which case as we
keep adding more REST endpoints, so my suggestion would be to keep all lower
case or all sentence case.
The next ones are questions/comments, no change desired.
- A good idea for later would be to time each request/response for each
endpoint and log the request that has come in and the response stats being sent
back along with the time taken. It has helped us in hRaven to know when a
request came in, what the params were and what the overall statistics about the
response were as well as how much time it took.
- Are we encoding/decoding the URL path/query parameters in rest client
somewhere? Some weird values may cause strange behavior with queries.
- In TimelineReaderWebServices line 371 and 424
@Path("/flowrun/{flowId}/{flowRunId}/")
Hmm. If this rest service is running outside of a hadoop cluster, wondering
what is the default cluster id? I would think we can set it in a config for
this rest service, is that the idea..
- Also, we now have a TestFlowDataGenerator class which generates test data for
flows. So we can use that the next time in the test cases.
> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
> Key: YARN-4075
> URL: https://issues.apache.org/jira/browse/YARN-4075
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: YARN-4075-YARN-2928.03.patch,
> YARN-4075-YARN-2928.04.patch, YARN-4075-YARN-2928.POC.1.patch,
> YARN-4075-YARN-2928.POC.2.patch
>
>
> We need to be able to query for flows and flow runs via REST.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
