[
https://issues.apache.org/jira/browse/YARN-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939668#comment-14939668
]
Dian Fu commented on YARN-3964:
-------------------------------
Hi [~Naganarasimha],
Thanks a lot for your review. Updated the patch accordingly.
{quote}
nodesToUpdateLabels == null is req ?
{quote}
Yes. If {{nodesToUpdateLabels}} isn't null, then {{nodesToUpdateLabels}}
contains all the cluster nodes (also including the newly registered nodes). In
this case, we don't need to add the newly registered nodes to
{{nodesToUpdateLabels}} any more.
{quote}
Hope you can share your test code for the RMNodeLabelMappingsUpdater with which
it i can test, hope you also have verified it .
{quote}
I have an implementation of {{RMNodeLabelMappingsUpdater}} which can fetch
nodes trust status from Mt. Wilson server and translate this trust status
information into node trust/untrust labels. As the Mt. Wilson is a commercial
software and the environment setup of Mt. Wilson server is a little
complicated, it would be difficult for you to use my test code directly. I
think you can write a simple implementation of {{RMNodeLabelMappingsUpdater}}
which returns hard-coded labels for the test.
> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>
> Key: YARN-3964
> URL: https://issues.apache.org/jira/browse/YARN-3964
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Dian Fu
> Assignee: Dian Fu
> Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch,
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch,
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch,
> YARN-3964.008.patch, YARN-3964.009.patch, YARN-3964.010.patch,
> YARN-3964.011.patch, YARN-3964.012.patch, YARN-3964.013.patch,
> YARN-3964.014.patch, YARN-3964.1.patch
>
>
> Currently, CLI/REST API is provided in Resource Manager to allow users to
> specify labels for nodes. For labels which may change over time, users will
> have to start a cron job to update the labels. This has the following
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more
> flexibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
