Devaraj K commented on YARN-3964:

Thanks [~leftnoteasy] for review and confirmation, [~Naganarasimha] and 
[~sunilg] for reviews. 

Thanks [~dian.fu] for the patch, It mostly looks good to me except these minor 

1. Can you update the descriptions for the new configs added in yarn-default.xml

+    The class to use as the node labels fetcher by ResourceManager. It should
+    extend org.apache.hadoop.yarn.server.resourcemanager.nodelabels.
+    RMNodeLabelsMappingProvider.

Can you update the description like below,
    'When node labels "yarn.node-labels.configuration-type" is
    of type "delegated-centralized", Administrators can configure 
    the class for fetching node labels by ResourceManager. Configured
    class needs to extend

+    The interval to use to update node labels by ResourceManager.

Can we think of having it like 'This interval is used to update the node labels 
by ResourceManager.'? And also can we describe here that if the value is '-1' 
then there will not be any timer task gets created.

2. In TestRMDelegatedNodeLabelsUpdater.java, can we have an assertion in catch 
block to check the expected exception message?

    } catch (Exception e) {
      // expected

3. Can you file a Jira to update the documentation for this?

> Support NodeLabelsProvider at Resource Manager side
> ---------------------------------------------------
>                 Key: YARN-3964
>                 URL: https://issues.apache.org/jira/browse/YARN-3964
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>         Attachments: YARN-3964 design doc.pdf, YARN-3964.002.patch, 
> YARN-3964.003.patch, YARN-3964.004.patch, YARN-3964.005.patch, 
> YARN-3964.006.patch, YARN-3964.007.patch, YARN-3964.007.patch, 
> YARN-3964.008.patch, YARN-3964.009.patch, YARN-3964.010.patch, 
> YARN-3964.011.patch, YARN-3964.012.patch, YARN-3964.013.patch, 
> YARN-3964.014.patch, YARN-3964.015.patch, YARN-3964.1.patch
> Currently, CLI/REST API is provided in Resource Manager to allow users to 
> specify labels for nodes. For labels which may change over time, users will 
> have to start a cron job to update the labels. This has the following 
> limitations:
> - The cron job needs to be run in the YARN admin user.
> - This makes it a little complicate to maintain as users will have to make 
> sure this service/daemon is alive.
> Adding a Node Labels Provider in Resource Manager will provide user more 
> flexibility.

This message was sent by Atlassian JIRA

Reply via email to