Varun Saxena commented on YARN-3864:

bq. I think sortedKeys can/should be private

bq. The URL patterns of the new endpoints seem bit unnatural. For example, 
"/apps" comes before the flow id and the flow run id.
apps indicates what we want to query and is a static path param. And flow id 
and flow run id are dynamic path params. In path, because they are mandatory 
for the query.
This follows the style for previous endpoints as well.
Even for entities endpoint for instance, we have entities in front(static part 
of URL) and then cluster id, app id etc.

The format we are following for URL endpoint is as under :
# A fixed static part in URL indicating what this query is meant for i.e. app, 
apps, entity, entities, flowrun, flows, etc. You can say this defines what 
table to peek into.
# Followed by dynamic mandatory parameters in URL path. Mainly parts which 
define the row key and need to be given by client mandatorily.
# Other things which are not mandatory for query are given via query parameters.

We can change it to have dynamic parts in front to follow an order of 
cluster->flow->flowrun->app->entity. But this is not specific to this endpoint. 

> Implement support for querying single app and all apps for a flow run
> ---------------------------------------------------------------------
>                 Key: YARN-3864
>                 URL: https://issues.apache.org/jira/browse/YARN-3864
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>            Priority: Blocker
>         Attachments: YARN-3864-YARN-2928.01.patch
> This JIRA will handle support for querying all apps for a flow run in HBase 
> reader implementation.
> And also REST API implementation for single app and multiple apps.

This message was sent by Atlassian JIRA

Reply via email to