Naganarasimha G R updated YARN-2729:
    Attachment: YARN-2729.20151310-1.patch

Thanks for the review [~rohithsharma],
bq. Does ScriptBasedNodeLabelsProvider is periodically runs similar to 
Yes as it extends AbstractNodeLabelsProvider it supports periodic execution.
bq. Is there anywher documented how the script output should be?
yes its documented in *yarn-default.xml* and javadocs for the class 
*ScriptBasedNodeLabelsProvider.java*. Do you have any other place in mind where 
it can be updated? 
bq. About the test TestNodeStatusUpdaterForLabels failing randomly.May be some 
race condition is exist.
Yes this is issue has been already raised as YARN-4169, but nutting to do in 
specific to this jira and was not actually reproducible in my local setup.
bq. When I run tests locally at package level i.e 
org.apache.hadoop.yarn.server.nodemanager.nodelabels, all the tests cases in 
TestScriptBasedNodeLabelsProvider are failing with below error
Not facing this issue, will sync offline with you on this.

Other issues have been handled in the patch along with one more minor issue 
which was got during testing, In ResourceTrackerService we are checking for 
distributed or delegated-centralized without checking for node labels enabled 
which caused unnecessary logs on RM side.

> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>                 Key: YARN-2729
>                 URL: https://issues.apache.org/jira/browse/YARN-2729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch, 
> YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch, 
> YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch, 
> YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch, 
> YARN-2729.20150402-1.patch, YARN-2729.20150404-1.patch, 
> YARN-2729.20150517-1.patch, YARN-2729.20150830-1.patch, 
> YARN-2729.20150925-1.patch, YARN-2729.20151310-1.patch
> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup . 

This message was sent by Atlassian JIRA

Reply via email to