Naganarasimha G R updated YARN-2729:
    Attachment: YARN-2729.20151019.patch

Thanks [~sunilg] for the comments and better late than never !
bq. We can do super.stop() first from ScriptBasedNodeLabelsProvider. But I feel 
it may not be better, so could we reset shexec to null after attached process 
is destroyed (may also need a null check in timetask if we do this).
IMHO i  feel the former approach is better than the latter as i am not inclined 
towards approach of having checks in the parts of code which gets frequently 
executed just to avoid corner case . Hence i am reverting the fix for the 
comment which was given by [~rohithsharma]. IIUC there are no impacts if we do 
super.serviceStop though theoritically its not the right way to do . Thoughts ?
bq. But if we have multiple lines from input string which starts with 
NODE_LABEL_PARTITION_PATTERN, then only last line will be set to 
nodePartitionLabel. I didnt understand this part. 
As discussed offline i have done these modifications as a node can belong to 
only one Partition Label and when we support Constraints we can support more 
patterns later.
Other issues i have fixed. If better approach is possible for first will rework.

> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>                 Key: YARN-2729
>                 URL: https://issues.apache.org/jira/browse/YARN-2729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch, 
> YARN-2729.20141031-1.patch, YARN-2729.20141120-1.patch, 
> YARN-2729.20141210-1.patch, YARN-2729.20150309-1.patch, 
> YARN-2729.20150322-1.patch, YARN-2729.20150401-1.patch, 
> YARN-2729.20150402-1.patch, YARN-2729.20150404-1.patch, 
> YARN-2729.20150517-1.patch, YARN-2729.20150830-1.patch, 
> YARN-2729.20150925-1.patch, YARN-2729.20151015-1.patch, 
> YARN-2729.20151019.patch, YARN-2729.20151310-1.patch, 
> YARN-2729.20151310-2.patch
> Support script based NodeLabelsProvider Interface in Distributed Node Label 
> Configuration Setup . 
> Miscellaneous Issues :
> # In configurationNodeLabelsProvider instead of taking multiple labels from 
> single configuration, we need to support exclusive configuration for 
> partition (single label).
> # Proper logging when registration of Node Fails
> # Classloader was not getting reset from custom class loader in 
> TestConfigurationNodeLabelsProvider.java which could make test cases fail in 
> certain conditions
> # In ResourceTrackerService we need to consider distributed configuration 
> only when node labels are enabled. leads to lots of logs in certain conditions
> # NodeLabelsProvider needs to be a interface rather than  abstract class 

This message was sent by Atlassian JIRA

Reply via email to