Naganarasimha G R updated YARN-4129:
    Attachment: YARN-4129-YARN-2928.002.patch

Hi [~sjlee0]
Thanks for the comments and sorry for the delay
bq. it'd be good to set things like createdTime directly on the entities to 
have consistent and uniform access to those important times. We can make those 
changes (if we agree) in that JIRA, though.
Yes this would be good for query and the other jira which you mentioned need to 
deal with much more things here i will just add for the basic RM entities when 
its created.

bq.  I'm slightly confused that (apart from l.396) the publisher is registered 
once to the RM itself and another time here to the RMActiveServices. Is it 
needed? How would the service stop work
Though this is not introduced from this patch missed to check it, IIUC its 
required in only one place and i think it should be sufficient if initialized 
in RM rather than active services as if any system events before HA needs to be 
captured then it will be usefull

bq. l.80: normally we call super.serviceStart() at the end rather than at the 
beginning, right?
I was of diff understanding on this and also i had seen other classes like 
ResourceTrackerService. I was of the understanding that 
{{super.serviceStart()}} needs to be called first and {{super.serviceStop()}} 
to be called last.

bq. we should add the JIRA id here in the comment so we that we can keep track. 
If not, could you please explain the TODO comment here?
That was for my reference i have removed it 

Other issues i have handled it and also one more addition is 
MultithreadedAsyncDispatcher is placing the events to particular 
asyncDispacther based on hashcode of applicationID which was missed as part of 

> Refactor the SystemMetricPublisher in RM to better support newer events
> -----------------------------------------------------------------------
>                 Key: YARN-4129
>                 URL: https://issues.apache.org/jira/browse/YARN-4129
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4129-YARN-2928.002.patch, 
> YARN-4129.YARN-2928.001.patch
> Currently to add new timeline event/ entity in RM side, one has to add a 
> method in publisher and a method in handler and create a new event class 
> which looks cumbersome and redundant. also further all the events might not 
> be required to be published in V1 & V2. So adopting the approach similar to 
> what was adopted in YARN-3045(NM side)

This message was sent by Atlassian JIRA

Reply via email to