Naganarasimha G R updated YARN-4129:
    Attachment: YARN-4129-YARN-2928.004.patch

Hi [~sjlee0],
Thanks for the comments, attaching a patch as per your comments,

bq. I think we should also override equals() (maybe with appId + eventType) as 
a good practice.
agree with you. also by doing in the above approach doesn't break the 
relationshipe between hashcode and equals. hence modifying as per ur suggesion

bq. why are we removing the license header? 
Missed it while rebasing the patch !

> Refactor the SystemMetricPublisher in RM to better support newer events
> -----------------------------------------------------------------------
>                 Key: YARN-4129
>                 URL: https://issues.apache.org/jira/browse/YARN-4129
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4129-YARN-2928.002.patch, 
> YARN-4129-YARN-2928.003.patch, YARN-4129-YARN-2928.004.patch, 
> YARN-4129.YARN-2928.001.patch
> Currently to add new timeline event/ entity in RM side, one has to add a 
> method in publisher and a method in handler and create a new event class 
> which looks cumbersome and redundant. also further all the events might not 
> be required to be published in V1 & V2. So adopting the approach similar to 
> what was adopted in YARN-3045(NM side)

This message was sent by Atlassian JIRA

Reply via email to