[
https://issues.apache.org/jira/browse/YARN-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965001#comment-14965001
]
Sunil G commented on YARN-4164:
-------------------------------
Hi [~rohithsharma]
Thanks for updating patch.
I have one suggestion here, {{UpdateApplicationPriorityResponse}} can now
report back the updated priority. But user wont understand what exactly is
this, as the name suggests only priority. So it can be more like
{{succefullyUpdatedPriority}}, rather than keeping a success flag.
Also when we skip priority update like in cases mentioned in YARN-4141, we can
set this return value as "null" or ""n/a", to indicate operation has not done.
Thoughts?
> Retrospect update ApplicationPriority API return type
> -----------------------------------------------------
>
> Key: YARN-4164
> URL: https://issues.apache.org/jira/browse/YARN-4164
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-4164.patch
>
>
> Currently {{ApplicationClientProtocol#updateApplicationPriority()}} API
> returns empty UpdateApplicationPriorityResponse response.
> But RM update priority to the cluster.max-priority if the given priority is
> greater than cluster.max-priority. In this scenarios, need to intimate back
> to client that updated priority rather just keeping quite where client
> assumes that given priority itself is taken.
> During application submission also has same scenario can happen, but I feel
> when
> explicitly invoke via ApplicationClientProtocol#updateApplicationPriority(),
> response should have updated priority in response.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
