Naganarasimha G R commented on YARN-4164:

Thanks for the patch [~rohithsharma], 
Yes as you mentioned, as per the patch priority will be returned as null if the 
app is in COMPLETED_APP_STATES, but IMHO i would not like to return null as it 
might lead to NPE in the client side if not properly handled, how about just 
returning the app's priority itself. If required to show proper logs then 
additional msg can be sent as part of response. The behavior what i have 
mentioned is also what It is currently in the REST side too.  Thoughts? 
If you agree to my comment i think we can to do some correction in the REST 
side too as we are makiyng use of {{rm.getClientRMService()}} i.e. return the 
priority from the UpdateApplicationPriorityResponse. 

> Retrospect update ApplicationPriority API return type
> -----------------------------------------------------
>                 Key: YARN-4164
>                 URL: https://issues.apache.org/jira/browse/YARN-4164
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4164.patch, 0002-YARN-4164.patch
> Currently {{ApplicationClientProtocol#updateApplicationPriority()}} API 
> returns empty UpdateApplicationPriorityResponse response.
> But RM update priority to the cluster.max-priority if the given priority is 
> greater than cluster.max-priority. In this scenarios, need to intimate back 
> to client that updated  priority rather just keeping quite where client 
> assumes that given priority itself is taken.
> During application submission also has same scenario can happen, but I feel 
> when 
> explicitly invoke via ApplicationClientProtocol#updateApplicationPriority(), 
> response should have updated priority in response. 

This message was sent by Atlassian JIRA

Reply via email to