[ 
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naganarasimha G R updated YARN-2934:
------------------------------------
    Attachment: YARN-2934.v1.002.patch

Thanks for the review comments [~steve_l] & [~varun_saxena],
Had kept test and the xml update to be in later patches as i thought of getting 
the feedback first, As i have received some comments and unit tests failing, i  
have updated them in the patch and with fixes for other review comments

bq. some minicluster one will suffice
Had anyway started of with mocking required in ContainerExecutor, hence went 
ahead with it. Hope it would not be an issue, please inform if otherwise

bq. try-finally construct to close it. Latter if this has to go in branch-2.6 
as well
As i was not sure whether this jira will be used in 2.6, hence used normal 
try-finally construct to close it. 

bq. FSDataInputStream#read is not guaranteed to read all the bytes which you 
have passed. You have to check number of bytes read and loop until read returns 
-1.
There was no explicit mention that if the length of the buffer is sufficiently 
given then also it might not read all the contents of the file in to the buffer 
in the read call, but checked with [~vinayrpet] and he confirmed the above is 
possible and hence used {{FSDataInputStream.readFully()}}

> Improve handling of container's stderr 
> ---------------------------------------
>
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch
>
>
> Most YARN applications redirect stderr to some file. That's why when 
> container launch fails with {{ExitCodeException}} the message is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to