Li Lu commented on YARN-4234:

Hi [~xgong], thanks for the update! General design LGTM, a few quick issues:
# Do we want to add those configs into yarn-default? 
# TimelineEntityGroupId, its string prefix does not contain the underscore, 
which appears to be inconsistent with app attempt id and application id. This 
may also be error pruning? 
# We may want to make it clear in the javadoc that some timeline client APIs 
are for ATS v1.5? 
# For sanity check, I agree with [~Naganarasimha] that our current approach 
requires the client config and server config to be consistent. I'm fine with 
moving forward here, but we may want to consider some mechanisms to let ATS v1 
server identify its own version and configs in future. 

> New put APIs in TimelineClient for ats v1.5
> -------------------------------------------
>                 Key: YARN-4234
>                 URL: https://issues.apache.org/jira/browse/YARN-4234
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-4234-20151111.2.patch, YARN-4234.1.patch, 
> YARN-4234.2.patch, YARN-4234.2015-11-12.1.patch, 
> YARN-4234.2015-11-12.1.patch, YARN-4234.20151109.patch, 
> YARN-4234.20151110.1.patch, YARN-4234.20151111.1.patch, YARN-4234.3.patch
> In this ticket, we will add new put APIs in timelineClient to let 
> clients/applications have the option to use ATS v1.5

This message was sent by Atlassian JIRA

Reply via email to