[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025746#comment-15025746
]
Chris Douglas commented on YARN-4248:
-------------------------------------
* Would it make sense to return 201
([Created|http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.2]) or
202
([Accepted|http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.3])
instead of 200
([OK|http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1]) from
{{submitReservation}}? The RFC specifies that the created resource should be a
URI, rather than just the reservation ID, so 200 is probably correct, but more
generic than perhaps it could be if there's a URI to track the reservation (as
in {{submitApplication}}).
* There are many NPEs possible in {{createReservationSubmissionRequest}} from
improperly formed requests, unless the serialization already rejects null
values. The existing services don't defend against this, so it may not be
relevant, but the submission logic could return more expressive errors.
* Odd AL header in {{ReservationRequestInfo}}, {{ReservationRequestsInfo}}
* Missing setter on {{ReservationSubmissionResponseInfo}}
* Missing {{\@XmlElement}} annotations on {{ReservationDefinitionInfo}} fields
{{arrival}}, {{deadline}}
* The test resources should be on the classpath, so the unit test could load
the sample JSON files by name instead of explicitly using {{src/test/resources}}
> REST API for submit/update/delete Reservations
> ----------------------------------------------
>
> Key: YARN-4248
> URL: https://issues.apache.org/jira/browse/YARN-4248
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-4248.2.patch, YARN-4248.3.patch, YARN-4248.patch
>
>
> This JIRA tracks work to extend the RMWebService to support REST APIs to
> submit/update/delete reservations. This will ease integration with external
> tools that are not java-based.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
