Carlo Curino commented on YARN-4248:

[~chris.douglas] thanks for the review. I addressed your comments (3-6) in the 
attached revision, and I am running this again in a cluster to check all works. 
I tested (2) and confirm that the system correctly reject the request without 
NPE in case of missing parameter. 

As you point out for both (1) and (2) the behavior is consistent with the 
remainder of the REST api, but it could be improved. I think we should circle 
back and discuss in general how "rest-y" we want the YARN REST api to be. Based 
on that we could revise this new apis, as well as the remainder.

> REST API for submit/update/delete Reservations
> ----------------------------------------------
>                 Key: YARN-4248
>                 URL: https://issues.apache.org/jira/browse/YARN-4248
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.8.0
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-4248.2.patch, YARN-4248.3.patch, YARN-4248.patch
> This JIRA tracks work to extend the RMWebService to support REST APIs to 
> submit/update/delete reservations. This will ease integration with external 
> tools that are not java-based.

This message was sent by Atlassian JIRA

Reply via email to