[ 
https://issues.apache.org/jira/browse/YARN-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026159#comment-15026159
 ] 

Naganarasimha G R commented on YARN-4304:
-----------------------------------------

Hi Sunil,
Thanks for working on this patch !
Few comments : 
# In the web page Max application(AM) resources for a user and queue should it 
not be at partition if mentioned per partition ? 
# Web rendering code formatting might not be needed as i think it was kept 
earlier for better readibility, Thoughts?
# ??existing bug in showing capacities for REST api /ws/v1/cluster/scheduler 
o/p when labels were enabled. Currently it shows only default label.?? Actually 
{{CapacitySchedulerQueueInfo}} already has {{QueueCapacitiesInfo}}  which 
encapsulates this list. and its encapsulted into one more object for better 
readibility (as done in other places). Also we should not delete any existing 
fields as it might break the compatability, because of this at the outer layer 
we have kept the same (capacities based on default Label) and added new fields 
for getting capacties of all labels

Have some queries on other parts once i get to analyze more will post again.

> AM max resource configuration per partition to be displayed/updated correctly 
> in UI and in various partition related metrics
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4304
>                 URL: https://issues.apache.org/jira/browse/YARN-4304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, 
> REST_and_UI.zip
>
>
> As we are supporting per-partition level max AM resource percentage 
> configuration, UI and various metrics also need to display correct 
> configurations related to same. 
> For eg: Current UI still shows am-resource percentage per queue level. This 
> is to be updated correctly when label config is used.
> - Display max-am-percentage per-partition in Scheduler UI (label also) and in 
> ClusterMetrics page
> - Update queue/partition related metrics w.r.t per-partition 
> am-resource-percentage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to