Naganarasimha G R commented on YARN-4304:

Thanks for the quick response [~sunilg]
bq. Scheduler UI displays queue inside each partition. So these resources will 
be per-queue per-partition. Hence we need not have to change label explicitly 
stating per-partition. Make sense
No, actually if you see we represent queue status in two blocks, so as to 
capture which queue information is for specific to label and which information 
is generic to queue under the headings {{queue Status for Partition}} and 
{{queue Status}}

bq. As of now if we see REST o/p for scheduler when used with labels, we can 
easily see usedCapacity is 0 (also others capacities). If its kept for default 
label , we need to make changes in variable name atleast else it will give a 
wrong meaning and wrong o/p. 
Yeah agree with it but assume the case where in node labels is not enabled and 
existing user is using it, in that case it will be break in compatability, 
Based on discussions with [~wangda]'s in YARN-4162 i had done the modifications 
in that way. refer 
 So basically you can discuss once with Wangda and then if we conclude on it 
then we can rework on YARN-4162 instead !
Also in some other places you have used the list directly we have encapsualted 
inside a class so that the structure of XML output is better. As per comment 
from [~bibinchundatt]

> AM max resource configuration per partition to be displayed/updated correctly 
> in UI and in various partition related metrics
> ----------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-4304
>                 URL: https://issues.apache.org/jira/browse/YARN-4304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, 
> 0003-YARN-4304.patch, REST_and_UI.zip
> As we are supporting per-partition level max AM resource percentage 
> configuration, UI and various metrics also need to display correct 
> configurations related to same. 
> For eg: Current UI still shows am-resource percentage per queue level. This 
> is to be updated correctly when label config is used.
> - Display max-am-percentage per-partition in Scheduler UI (label also) and in 
> ClusterMetrics page
> - Update queue/partition related metrics w.r.t per-partition 
> am-resource-percentage

This message was sent by Atlassian JIRA

Reply via email to