Wangda Tan commented on YARN-4304:

Hi [~sunilg],
Took a look at REST API implementation of latest patch, some comments:

By design, PartitionResourcesInfo/ResourcesInfo should be used by 
user/queue/app, so we need to make fields and usage generic to these components.
- amResourceLimit is meaningful to all components. App doesn't use that field 
for now, but we can keep it and set it to infinite.
- userAMResourceLimit is not meaningful to queue/app, and it's overlap to 
user.resourcesInfo.amResourceLimit, I suggest to remove it and we can use 
amResourceLimit of first user of queues to show on UI. Another reason is in the 
future we could have different users has different amResourceLimits.

And also ResourcesInfo is RESTful mapping to ResourceUsage, so necessary 
changes need to be added to ResourceUsage (Maybe rename ResourceUsage to 
ResourcesInformation?) as well. Renaming could be done in a separated JIRA, but 
I suggest to change ResourceUsage implementation at the same JIRA.

If you agree with above, ResourcesInfo's constructor shouldn't relate to 
LeafQueue and considerAMUsage, it should simply copy fields from ResourceUsage.

> AM max resource configuration per partition to be displayed/updated correctly 
> in UI and in various partition related metrics
> ----------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-4304
>                 URL: https://issues.apache.org/jira/browse/YARN-4304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, 
> 0003-YARN-4304.patch, 0004-YARN-4304.patch, REST_and_UI.zip
> As we are supporting per-partition level max AM resource percentage 
> configuration, UI and various metrics also need to display correct 
> configurations related to same. 
> For eg: Current UI still shows am-resource percentage per queue level. This 
> is to be updated correctly when label config is used.
> - Display max-am-percentage per-partition in Scheduler UI (label also) and in 
> ClusterMetrics page
> - Update queue/partition related metrics w.r.t per-partition 
> am-resource-percentage

This message was sent by Atlassian JIRA

Reply via email to