Sunil G commented on YARN-4304:

bq.I think the longer term fix should be, add a by-partition info to queue 
metrics, including max/guaranteed/available/used, etc. I can help to review 
Yes. This looks fine for me. I will track this with a different JIRA. This new 
ticket will track the cluster metrics total memory when used with labels.

bq.How about call them calculateAndGetAMResourceLimitPerPartition and 
+1. Since we have this calculated information, we can make use of same. I will 
make the changes.

I will upload REST/UI screen shots along with updated patch

bq.Is there any concern of you for this approach?
I was slightly confused by earlier comment. Ideally we can make use of 
{{users}}, but we may need to get the first user and get his AM Limit. This is 
perfectly fine for now until we have per-user-am-limit.  

> AM max resource configuration per partition to be displayed/updated correctly 
> in UI and in various partition related metrics
> ----------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-4304
>                 URL: https://issues.apache.org/jira/browse/YARN-4304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, 
> 0003-YARN-4304.patch, 0004-YARN-4304.patch, 0005-YARN-4304.patch, 
> 0005-YARN-4304.patch, REST_and_UI.zip
> As we are supporting per-partition level max AM resource percentage 
> configuration, UI and various metrics also need to display correct 
> configurations related to same. 
> For eg: Current UI still shows am-resource percentage per queue level. This 
> is to be updated correctly when label config is used.
> - Display max-am-percentage per-partition in Scheduler UI (label also) and in 
> ClusterMetrics page
> - Update queue/partition related metrics w.r.t per-partition 
> am-resource-percentage

This message was sent by Atlassian JIRA

Reply via email to