Varun Vasudev commented on YARN-4451:

Agree with points (1) and (2) and (5).

Disagree with point (3). One of the reasons we used the same name is to avoid 
filling up the disk and having to manage the disk space.

With regards to point (4) - I didn't test the feature to make sure it works 
with FairScheduler - have you checked that it generates the logs correctly?

> Some improvements required in Dump scheduler logs
> -------------------------------------------------
>                 Key: YARN-4451
>                 URL: https://issues.apache.org/jira/browse/YARN-4451
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
> Though dumping scheduler logs is very useful option there are few nits in 
> using it
> * for naive or first time user its hard to understand what does {{"Time"}} 
> stand for past or future, IMO it would be slightly better to set the name in 
> the ui as {{"Time Period"}}
> * success message should give where the logs will be found and the file name
> * Need to append the time stamp and the period to the file name, so that its 
> not over ridden
> * From code it seems like it always returns {{"Capacity scheduler logs are 
> being created"}} even though the fair scheduler is set
> * Would having cli option in {{"yarn rmadmin"}}  will also be helpful ? 

This message was sent by Atlassian JIRA

Reply via email to