Naganarasimha G R commented on YARN-4451:

Hi [~vvasudev], Thanks for the feeback, 
bq.  One of the reasons we used the same name is to avoid filling up the disk 
and having to manage the disk space.
Well i guessed that would be the reason but the problem is it overwrites 
without any warning/alert ! So either we need to provide a message that file 
will be overwritten or may be while creating we can keep configurable number of 
logs, say 5.

bq.  I didn't test the feature to make sure it works with FairScheduler - have 
you checked that it generates the logs correctly?
neither did i test just was checking the patch in the jira to see if it 
supports any CLI and found this log/ return message.

Also we observed that DEBUG logs were only present and *not* the INFO logs and 
usually we do not put debug logs for the same info log message, so was 
wondering whether its feasible to collect INFO logs too in the same log file so 
that analysis is faster ? 

and one more issue is when i tried the REST url "http://<rm http 
address>/ws/v1/cluster/scheduler/logs" using wget, i am getting 
WebApplicationException just wanted to confirm whether i missing something !

> Some improvements required in Dump scheduler logs
> -------------------------------------------------
>                 Key: YARN-4451
>                 URL: https://issues.apache.org/jira/browse/YARN-4451
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
> Though dumping scheduler logs is very useful option there are few nits in 
> using it
> * for naive or first time user its hard to understand what does {{"Time"}} 
> stand for past or future, IMO it would be slightly better to set the name in 
> the ui as {{"Time Period"}}
> * success message should give where the logs will be found and the file name
> * Need to append the time stamp and the period to the file name, so that its 
> not over ridden
> * From code it seems like it always returns {{"Capacity scheduler logs are 
> being created"}} even though the fair scheduler is set
> * Would having cli option in {{"yarn rmadmin"}}  will also be helpful ? 

This message was sent by Atlassian JIRA

Reply via email to