[ 
https://issues.apache.org/jira/browse/YARN-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059297#comment-15059297
 ] 

Li Lu commented on YARN-4445:
-----------------------------

Thanks for the contribution [~zhanzhang]! The patch LGTM. +1 pending Jenkins. 
Meanwhile, I'd like to check if anyone got any ongoing work that is conflicting 
with the fixes in this patch? If not, I'd prefer to quickly flip this in the 
codebase so that we can completely eliminate flowId. 

> Unify the term flowId and flowName in timeline v2 codebase
> ----------------------------------------------------------
>
>                 Key: YARN-4445
>                 URL: https://issues.apache.org/jira/browse/YARN-4445
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Zhan Zhang
>              Labels: refactor
>         Attachments: YARN-4445-feature-YARN-2928.001.patch, YARN-4445.patch
>
>
> Flow names are not sufficient to identify a flow. I noticed we used both 
> "flowName" and "flowId" to point to the same thing. We need to unify them to 
> flowName. Otherwise, front end users may think flow id is a top level concept 
> and try to directly locate a flow by its flow id.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to