Li Lu commented on YARN-4445:

I lean toward "flowName" since this is not indicating it is sufficient to 
identify a flow via this field. A "flowId" may give other people such feeling, 
which is not correct. I'll wait for about a day to commit this patch, but 
please feel free to share your concerns. 

> Unify the term flowId and flowName in timeline v2 codebase
> ----------------------------------------------------------
>                 Key: YARN-4445
>                 URL: https://issues.apache.org/jira/browse/YARN-4445
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Zhan Zhang
>              Labels: refactor
>         Attachments: YARN-4445-feature-YARN-2928.001.patch, YARN-4445.patch
> Flow names are not sufficient to identify a flow. I noticed we used both 
> "flowName" and "flowId" to point to the same thing. We need to unify them to 
> flowName. Otherwise, front end users may think flow id is a top level concept 
> and try to directly locate a flow by its flow id.  

This message was sent by Atlassian JIRA

Reply via email to