Wangda Tan commented on YARN-4304:

1) LeafQueue:
- amLimitForEmptyLabel -> amLimit?
- Since calculateAndGetAMResourceLimitPerPartition set amLimit per partition, 
do you still need the map: amPartitionLimit?
- Could you update user am-limit (in User.resourceUsage) as well when computing 
user am-limit at activateApplications? Ideally it's better to directly return 
user am-limit when call 

2) CapacitySchedulerPage
- Instead of getAMResourceLimit()
      if (usersList.isEmpty()) {
        // If no users are present, consider AM Limit for that queue.
        userAMResourceLimit = resourceUsages.getAMResourceLimit();
Shouldn't you use getAMResourceLimit(partition)?

> AM max resource configuration per partition to be displayed/updated correctly 
> in UI and in various partition related metrics
> ----------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-4304
>                 URL: https://issues.apache.org/jira/browse/YARN-4304
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, 
> 0003-YARN-4304.patch, 0004-YARN-4304.patch, 0005-YARN-4304.patch, 
> 0005-YARN-4304.patch, 0006-YARN-4304.patch, 0007-YARN-4304.patch, 
> REST_and_UI.zip
> As we are supporting per-partition level max AM resource percentage 
> configuration, UI and various metrics also need to display correct 
> configurations related to same. 
> For eg: Current UI still shows am-resource percentage per queue level. This 
> is to be updated correctly when label config is used.
> - Display max-am-percentage per-partition in Scheduler UI (label also) and in 
> ClusterMetrics page
> - Update queue/partition related metrics w.r.t per-partition 
> am-resource-percentage

This message was sent by Atlassian JIRA

Reply via email to