Subru Krishnan commented on YARN-4195:

Thanks [~curino] for the patch. I looked at it (excluding the parts that will 
be addressed by YARN-4476 and YARN-4523) and had a few thoughts on the API 
  * Can we use _Resource_ instead of in _RMNodeLabel_ 
  * We should deprecate _getTotalCommittedResources_ from *PlanView* in favor 
of _getAvailableResources_ based on the enhancements that were made in YARN-4358
  * I feel we should have a single API for _getTotalCapacity, 
getEarliestStartTime, getLastEndTime_ etc in *PlanView* which takes in a node 
label. We could have a reserved keyword say ALL or * to specify that we want it 
to be aggregated across all labels (inc NO_LABEL)

Other than that, please find minor comments below:
  * In *AbstractReservationSystem::initializePlan* use the preinitialized 
_UTCClock_ instead of creating one for every _Plan_
  * The check for _user_ in *InMemoryPlan::incrementAllocation* can be made 
outside the for loops
  * The check for _node labels_ in *InMemoryPlan::incrementAllocation* can be 
made outside the inner for loop
  * Looks like there are minor formatting issues in *PlanView*

> Support of node-labels in the ReservationSystem "Plan"
> ------------------------------------------------------
>                 Key: YARN-4195
>                 URL: https://issues.apache.org/jira/browse/YARN-4195
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-4195.patch
> As part of YARN-4193 we need to enhance the InMemoryPlan (and related 
> classes) to track the per-label available resources, as well as the per-label
> reservation-allocations.

This message was sent by Atlassian JIRA

Reply via email to