Carlo Curino commented on YARN-4195:

[~subru] thanks for the review. I agree with most of what you say.

 * The RMNodeLabel was more of a future-proofing. That class contains more info 
regarding actual nodes carrying that the label etc., which in the future we 
might want to leverage. At the same time, other ongoing work point at using the 
RLESparseResourceAllocation to represent the amount of resources available (to 
allow to represent time-varying plan capacity). As such I second your 
suggestion to switch to Resource (or maybe RLE directly).
 * We need to wait for YARN-4359 and YARN-4360 as well to settle, but given 
that work I agree we could remove a few calls from PlanView. (I will add the 
 * As I mentioned in person, the initial attempt (which I am not very happy 
with) was to follow what happens in the rest of the CS, i.e., the old method 
signature (without any label specified) implicitly refers to what should happen 
for the NO_LABEL partition. I think this makes sense only temporarily, and for 
legacy purposes. Since in the ReservationSystem we have less of a legacy usage, 
I agree with your proposal to switch to explicit use of labels at all times, 
where one can specify ALL or NO_LABEL explicitly. Regarding the semantics of a 
null label  expression, I am leaning towards the interpretation of it as "no 
constraints" and therefore meaning of a "any label is fine" than the implicit 
semantics of NO_LABEL only carried over from CS. Thoughts? 

ACK on all the minor comments.

> Support of node-labels in the ReservationSystem "Plan"
> ------------------------------------------------------
>                 Key: YARN-4195
>                 URL: https://issues.apache.org/jira/browse/YARN-4195
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-4195.patch
> As part of YARN-4193 we need to enhance the InMemoryPlan (and related 
> classes) to track the per-label available resources, as well as the per-label
> reservation-allocations.

This message was sent by Atlassian JIRA

Reply via email to