[ 
https://issues.apache.org/jira/browse/YARN-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090270#comment-15090270
 ] 

Sangjin Lee commented on YARN-4224:
-----------------------------------

I agree with what you said about escaping the separators. I'd like to mention 
that it would be good if both the separator and the escaped separator are 
URL-safe (i.e. don't have to be URL-encoded). That way things won't get too 
complicated and the URLs won't look cryptic. 

bq. But should we make the UID key itself configurable ? This is regarding the 
key we choose to store UID against in info field(in response).

I'm not quite sure what you meant by the above. Do you mean what key in the 
info field in the response under which to return the UID? Should that be 
configurable? I don't see a whole lot of value for making that configurable.

bq. Regarding entity type, Li Lu, are you fine with having it as part of URL(as 
a mandatory param) ? I would prefer to have it as part of URL if there is no 
use case. Sangjin Lee, what you think on this ?

Is it a choice between having the entity type as part of the path (e.g. 
".../YARN_CONTAINER/...") as opposed to having it as a query param (e.g. 
"...?entityType=YARN_CONTAINER")? I would prefer if it was part of the path, 
but I'm open to other views. Either way, I think it should be mandatory.

> Support fetching entities by UID and change the REST interface to conform to 
> current REST APIs' in YARN
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4224
>                 URL: https://issues.apache.org/jira/browse/YARN-4224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4224-YARN-2928.01.patch, 
> YARN-4224-feature-YARN-2928.wip.02.patch, 
> YARN-4224-feature-YARN-2928.wip.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to