[
https://issues.apache.org/jira/browse/YARN-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095835#comment-15095835
]
Rohith Sharma K S commented on YARN-4389:
-----------------------------------------
Hi [~sunilg], thanks for working on the patch.
Overall patch looks good to me,
One nit : optimization
# can you check first app level blacklisting enabled or not. And later go for
global blacklisting initialzation. Now , global level variable initialization
are done first and then, checking for app level which we can optimize a bit.
> "yarn.am.blacklisting.enabled" and
> "yarn.am.blacklisting.disable-failure-threshold" should be app specific
> rather than a setting for whole YARN cluster
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4389
> URL: https://issues.apache.org/jira/browse/YARN-4389
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications
> Reporter: Junping Du
> Assignee: Sunil G
> Priority: Critical
> Attachments: 0001-YARN-4389.patch, 0002-YARN-4389.patch,
> 0003-YARN-4389.patch, 0004-YARN-4389.patch, 0005-YARN-4389.patch
>
>
> "yarn.am.blacklisting.enabled" and
> "yarn.am.blacklisting.disable-failure-threshold" should be application
> specific rather than a setting in cluster level, or we should't maintain
> amBlacklistingEnabled and blacklistDisableThreshold in per rmApp level. We
> should allow each am to override this config, i.e. via submissionContext.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
