[
https://issues.apache.org/jira/browse/YARN-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096323#comment-15096323
]
Junping Du commented on YARN-4389:
----------------------------------
Thanks [~sunilg] for delivering the patch and [~rohithsharma] for reviewing it.
The patch looks fine in overall except one issue:
if submissionContext.getAMBlackListRequest() is null that means app doesn't
have specific requirement on blacklist policy, then we should use cluster's
setting instead.
> "yarn.am.blacklisting.enabled" and
> "yarn.am.blacklisting.disable-failure-threshold" should be app specific
> rather than a setting for whole YARN cluster
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4389
> URL: https://issues.apache.org/jira/browse/YARN-4389
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications
> Reporter: Junping Du
> Assignee: Sunil G
> Priority: Critical
> Attachments: 0001-YARN-4389.patch, 0002-YARN-4389.patch,
> 0003-YARN-4389.patch, 0004-YARN-4389.patch, 0005-YARN-4389.patch,
> 0006-YARN-4389.patch
>
>
> "yarn.am.blacklisting.enabled" and
> "yarn.am.blacklisting.disable-failure-threshold" should be application
> specific rather than a setting in cluster level, or we should't maintain
> amBlacklistingEnabled and blacklistDisableThreshold in per rmApp level. We
> should allow each am to override this config, i.e. via submissionContext.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
