[
https://issues.apache.org/jira/browse/YARN-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096701#comment-15096701
]
Junping Du commented on YARN-4265:
----------------------------------
Thanks [~gtCarrera9] for patient and updating the patch.
A few minor comments:
For new algorithm in cleanLogs(), I think it only works for specific log
directory/file structure. Isn't it? If so, can you document it as javadoc on
specific log structure it applies on?
For new added test case, please correct some naming issues with DIRs in each
case. Also, instead of calling {{fs.getFileStatus(appDirClean)}} and catch
exceptions for file/directory non-existing, it is more convenient to use
{{fs.exists(Path)}}.
Please correct javadoc warning reported by Jenkins also.
> Provide new timeline plugin storage to support fine-grained entity caching
> --------------------------------------------------------------------------
>
> Key: YARN-4265
> URL: https://issues.apache.org/jira/browse/YARN-4265
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-4265-trunk.001.patch, YARN-4265-trunk.002.patch,
> YARN-4265-trunk.003.patch, YARN-4265-trunk.004.patch,
> YARN-4265-trunk.005.patch, YARN-4265.YARN-4234.001.patch,
> YARN-4265.YARN-4234.002.patch
>
>
> To support the newly proposed APIs in YARN-4234, we need to create a new
> plugin timeline store. The store may have similar behavior as the
> EntityFileTimelineStore proposed in YARN-3942, but cache date in cache id
> granularity, instead of application id granularity. Let's have this storage
> as a standalone one, instead of updating EntityFileTimelineStore, to keep the
> existing store (EntityFileTimelineStore) stable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
