[ 
https://issues.apache.org/jira/browse/YARN-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097285#comment-15097285
 ] 

Jason Lowe commented on YARN-4371:
----------------------------------

hasAnyOtherCLIOptions was factored out but only has one very specific use.  The 
name makes it sound generic, but it is far from it.  It would be better if the 
method took an option as an argument and checked for anything other than the 
specified option by walking the options iterator or the options array from 
getOptions.  Otherwise the method should be renamed to something like 
hasOptionsIncompatibleForKill to indicate the very specific use case.

It would be much simpler and clearer if we didn't abuse exceptions to act like 
return codes.  killApplication should simply return an exit code, and then we 
don't need to do the bogus throw inside killApplication nor the try/catch when 
it's called.

> "yarn application -kill" should take multiple application ids
> -------------------------------------------------------------
>
>                 Key: YARN-4371
>                 URL: https://issues.apache.org/jira/browse/YARN-4371
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4371.patch, 0002-YARN-4371.patch, 
> 0003-YARN-4371.patch, 0004-YARN-4371.patch
>
>
> Currently we cannot pass multiple applications to "yarn application -kill" 
> command. The command should take multiple application ids at the same time. 
> Each entries should be separated with whitespace like:
> {code}
> yarn application -kill application_1234_0001 application_1234_0007 
> application_1234_0012
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to