[
https://issues.apache.org/jira/browse/YARN-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102026#comment-15102026
]
Jason Lowe commented on YARN-4371:
----------------------------------
Thanks for updating the patch, Sunil!
Why aren't we simply returning whatever result comes back from killApplication?
It's weird to check it against errorCode (which is basically a constant), and
this will cause problems if someone later comes along and decides to change the
default value of errorCode in the run method.
This comment doesn't match the behavior of the code, as it will only return an
error if it failed to kill _all_ of the specified applications.
{noformat}
// kill application has failed for one or all applications.
{noformat}
As mentioned above, we can simply have the run method return whatever error
code killApplication returned, and move the comment (updated for correctness)
to the killApplication method.
There should be a unit test checking that we are properly complaining when
incompatible options are specified along with the kill.
> "yarn application -kill" should take multiple application ids
> -------------------------------------------------------------
>
> Key: YARN-4371
> URL: https://issues.apache.org/jira/browse/YARN-4371
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Tsuyoshi Ozawa
> Assignee: Sunil G
> Attachments: 0001-YARN-4371.patch, 0002-YARN-4371.patch,
> 0003-YARN-4371.patch, 0004-YARN-4371.patch, 0005-YARN-4371.patch,
> 0006-YARN-4371.patch
>
>
> Currently we cannot pass multiple applications to "yarn application -kill"
> command. The command should take multiple application ids at the same time.
> Each entries should be separated with whitespace like:
> {code}
> yarn application -kill application_1234_0001 application_1234_0007
> application_1234_0012
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
