[ 
https://issues.apache.org/jira/browse/YARN-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122368#comment-15122368
 ] 

Jason Lowe commented on YARN-3102:
----------------------------------

Shouldn't this {{get}} be a {{remove}}?  Otherwise I think we leave the old 
node in the inactive list.
{code}
      RMNode previousRMNode = rmNode.context.getInactiveRMNodes().get(nodeId);
      if (previousRMNode != null) {
        rmNode.updateMetricsForRejoinedNode(previousRMNode.getState());
      } else {
{code}

Why is MockRM#drainEvents a protected function instead of public?  Seems like 
this would make it difficult to use from other java packages without needlessly 
deriving from it.

Nit: The new writeHostsFile method uses a local variable that eclipses the 
existing {{hostFile}} instance variable.  It would be a bit clearer if that 
aliasing wasn't there.

> Decommisioned Nodes not listed in Web UI
> ----------------------------------------
>
>                 Key: YARN-3102
>                 URL: https://issues.apache.org/jira/browse/YARN-3102
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>         Environment: 2 Node Manager and 1 Resource Manager 
>            Reporter: Bibin A Chundatt
>            Assignee: Kuhu Shukla
>            Priority: Minor
>         Attachments: YARN-3102-v1.patch, YARN-3102-v2.patch, 
> YARN-3102-v3.patch, YARN-3102-v4.patch, YARN-3102-v5.patch, 
> YARN-3102-v6.patch, YARN-3102-v7.patch
>
>
> Configure yarn.resourcemanager.nodes.exclude-path in yarn-site.xml to 
> yarn.exlude file In RM1 machine
> Add Yarn.exclude with NM1 Host Name 
> Start the node as listed below NM1,NM2 Resource manager
> Now check Nodes decommisioned in /cluster/nodes
> Number of decommisioned node is listed as 1 but Table is empty in 
> /cluster/nodes/decommissioned (detail of Decommision node not shown)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to