[ 
https://issues.apache.org/jira/browse/YARN-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129368#comment-15129368
 ] 

Junping Du commented on YARN-3769:
----------------------------------

Hi [~eepayne], it looks like the patch for branch-2.6 has some problem:
{code}
+        Resource headroom = Resources.subtract(
+            computeUserLimit(app, resources, minimumAllocation, user, null),
+            user.getConsumedResourceByLabel(CommonNodeLabelsManager.NO_LABEL));
{code}
{{user.getConsumedResourceByLabel()}} is not defined in branch-2.6. Shall we 
use {{user.getUsed()}} instead as patch for branch-2.7? Also, there are test 
code conflict with branch-2.6.

> Consider user limit when calculating total pending resource for preemption 
> policy in Capacity Scheduler
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3769
>                 URL: https://issues.apache.org/jira/browse/YARN-3769
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>    Affects Versions: 2.6.0, 2.7.0, 2.8.0
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>             Fix For: 2.7.3
>
>         Attachments: YARN-3769-branch-2.002.patch, 
> YARN-3769-branch-2.6.001.patch, YARN-3769-branch-2.7.002.patch, 
> YARN-3769-branch-2.7.003.patch, YARN-3769-branch-2.7.005.patch, 
> YARN-3769-branch-2.7.006.patch, YARN-3769-branch-2.7.007.patch, 
> YARN-3769.001.branch-2.7.patch, YARN-3769.001.branch-2.8.patch, 
> YARN-3769.003.patch, YARN-3769.004.patch, YARN-3769.005.patch
>
>
> We are seeing the preemption monitor preempting containers from queue A and 
> then seeing the capacity scheduler giving them immediately back to queue A. 
> This happens quite often and causes a lot of churn.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to