[
https://issues.apache.org/jira/browse/YARN-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146957#comment-15146957
]
Kai Sasaki commented on YARN-4648:
----------------------------------
[~ozawa] Thank you so much for reviewing!
{code}
Why not reusing startResourceManager(threshold) with the threshold larger than
1.0f?
{code}
The main different between {{startResourceManager}} and
{{startResourceManagerWithoutThreshold}} seems to be Yarn configuration and
initialization of {{FairScheduler}}. We can reuse {{startResourceManager}} but
I'm afraid we cannot be confident not to break existing test code. If a code
used by {{TestFairSchedulerPreemption}} (in the case
{{startResourceManagerWithoutThreshold}}) is changed, we cannot say the test
code after moving checks the same functionality as before moving. Can we change
initialization code?
> Move preemption related tests from TestFairScheduler to
> TestFairSchedulerPreemption
> -----------------------------------------------------------------------------------
>
> Key: YARN-4648
> URL: https://issues.apache.org/jira/browse/YARN-4648
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Kai Sasaki
> Labels: newbie++
> Attachments: YARN-4648.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
