[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159986#comment-15159986
]
Sangjin Lee commented on YARN-3863:
-----------------------------------
Sorry for taking a long time to review this [~varun_saxena]. I've begun to
review the patch, and will provide my feedback soon.
It seems that the current patch includes some changes that are somewhat
separate from the main changes (filters). I'm talking about changes in
{{HBaseTimelineWriterImpl}} and the associated changes in {{\*Column\*}} and
{{ColumnHelper}}. Are those changes needed by the filter changes, or can they
be separated from the main filter changes? If the latter, it might make sense
to address only the filter changes in this JIRA and handle the other changes in
a later work. That would also make this patch easier to review. Let me know
what you think.
> Support complex filters in TimelineReader
> -----------------------------------------
>
> Key: YARN-3863
> URL: https://issues.apache.org/jira/browse/YARN-3863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3863-YARN-2928.v2.01.patch,
> YARN-3863-YARN-2928.v2.02.patch, YARN-3863-feature-YARN-2928.wip.003.patch,
> YARN-3863-feature-YARN-2928.wip.01.patch,
> YARN-3863-feature-YARN-2928.wip.02.patch,
> YARN-3863-feature-YARN-2928.wip.04.patch,
> YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the
> filter conditions hold true i.e. only AND operation is supported. We can
> support OR operation for the filters as well. Additionally as primary backend
> implementation is HBase, we can design our filters in a manner, where they
> closely resemble HBase Filters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
