[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160034#comment-15160034
]
Sangjin Lee commented on YARN-3863:
-----------------------------------
If I'm reading this right, the key changes seem to be in
{{TimelineStorageUtils}} (in methods such as {{matchRelations()}}). I'm going
over the changes and it's not exactly easiest to read. :)
Can you elaborate on the main logic of these methods (they all seem pretty
similar to one another)? One reason I'm having a bit of trouble is that I think
the outermost logic should be applying ANDs and ORs on the individual recursive
calls and the inner logic should be about handling specific types of filters.
But it seems like ANDs and ORs are sprinkled throughout the method. It's not
clear if my mental model matches what we have here (or it should). In any case,
some clarifications of the implementation logic would be tremendously helpful.
> Support complex filters in TimelineReader
> -----------------------------------------
>
> Key: YARN-3863
> URL: https://issues.apache.org/jira/browse/YARN-3863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3863-YARN-2928.v2.01.patch,
> YARN-3863-YARN-2928.v2.02.patch, YARN-3863-feature-YARN-2928.wip.003.patch,
> YARN-3863-feature-YARN-2928.wip.01.patch,
> YARN-3863-feature-YARN-2928.wip.02.patch,
> YARN-3863-feature-YARN-2928.wip.04.patch,
> YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the
> filter conditions hold true i.e. only AND operation is supported. We can
> support OR operation for the filters as well. Additionally as primary backend
> implementation is HBase, we can design our filters in a manner, where they
> closely resemble HBase Filters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
