[
https://issues.apache.org/jira/browse/YARN-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175802#comment-15175802
]
Varun Saxena commented on YARN-4700:
------------------------------------
[~Naganarasimha], had a glance at the patch. It looks good to me in general.
# Changes in TestTimelineReaderWebServicesHBaseStorage l.801 are not required.
# I think javadoc should be fixable.
# In FlowActivityEntityRowKey#getRowKey, the javadoc says we are passing top of
the day timestamp. But we are not. We are calculating it inside. We can change
the param name and description(say to something like event timestamp).
# Although created time should be fine but should we use event timestamp at
both the places ? Just for consistency.
> ATS storage has one extra record each time the RM got restarted
> ---------------------------------------------------------------
>
> Key: YARN-4700
> URL: https://issues.apache.org/jira/browse/YARN-4700
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Li Lu
> Assignee: Naganarasimha G R
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-4700-YARN-2928.v1.001.patch,
> YARN-4700-YARN-2928.v1.002.patch, YARN-4700-YARN-2928.wip.patch
>
>
> When testing the new web UI for ATS v2, I noticed that we're creating one
> extra record for each finished application (but still hold in the RM state
> store) each time the RM got restarted. It's quite possible that we add the
> cluster start timestamp into the default cluster id, thus each time we're
> creating a new record for one application (cluster id is a part of the row
> key). We need to fix this behavior, probably by having a better default
> cluster id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
