[
https://issues.apache.org/jira/browse/YARN-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176364#comment-15176364
]
Vrushali C commented on YARN-4700:
----------------------------------
Thanks [~Naganarasimha Garla] for the updated patch. Overall it looks good.
I have an extremely minor comment, please make the change _only_ if you plan to
make another patch, else we can make those changes later.
- Lines 195 and 200 in TestFlowDataGenerator are commented out in the patch, we
can remove them.
+ 1 otherwise.
> ATS storage has one extra record each time the RM got restarted
> ---------------------------------------------------------------
>
> Key: YARN-4700
> URL: https://issues.apache.org/jira/browse/YARN-4700
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Li Lu
> Assignee: Naganarasimha G R
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-4700-YARN-2928.v1.001.patch,
> YARN-4700-YARN-2928.v1.002.patch, YARN-4700-YARN-2928.v1.003.patch,
> YARN-4700-YARN-2928.wip.patch
>
>
> When testing the new web UI for ATS v2, I noticed that we're creating one
> extra record for each finished application (but still hold in the RM state
> store) each time the RM got restarted. It's quite possible that we add the
> cluster start timestamp into the default cluster id, thus each time we're
> creating a new record for one application (cluster id is a part of the row
> key). We need to fix this behavior, probably by having a better default
> cluster id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
