[
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180274#comment-15180274
]
Varun Saxena commented on YARN-3863:
------------------------------------
[~sjlee0], wanted to know what you mean by this comment.
bq. I'm not sure if this is an issue or not, but I remember there were cases
where we join an empty string at the end to have the qualifier end with the
separator, and that was for a reason. I hope this patch did not change an
occurrence of that inadvertently.
{{getCompoundColumnQualifierBytes}} is a new method added in ColumnHelper. So
its not changing anything. It has been used in filter implementation and in
hbase writer implementation. Do you mean has the behavior changed because of
the way it has been used in HBaseTimelineWriterImpl ?
Regarding this comment,
bq. I'm still not sure I understand. Is this a temporary thing until YARN-4447
is addressed?
Yes its temporary.
> Support complex filters in TimelineReader
> -----------------------------------------
>
> Key: YARN-3863
> URL: https://issues.apache.org/jira/browse/YARN-3863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3863-YARN-2928.v2.01.patch,
> YARN-3863-YARN-2928.v2.02.patch, YARN-3863-YARN-2928.v2.03.patch,
> YARN-3863-feature-YARN-2928.wip.003.patch,
> YARN-3863-feature-YARN-2928.wip.01.patch,
> YARN-3863-feature-YARN-2928.wip.02.patch,
> YARN-3863-feature-YARN-2928.wip.04.patch,
> YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the
> filter conditions hold true i.e. only AND operation is supported. We can
> support OR operation for the filters as well. Additionally as primary backend
> implementation is HBase, we can design our filters in a manner, where they
> closely resemble HBase Filters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
