[ 
https://issues.apache.org/jira/browse/YARN-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181317#comment-15181317
 ] 

Sangjin Lee commented on YARN-3863:
-----------------------------------

I was specifically referring to a case like the following. In current code,

{code:title=HBaseTimelineWriterImpl.java}
411                   // add separator since event key is empty         
412                   byte[] compoundColumnQualifierBytes =             
413                       Separator.VALUES.join(columnQualifierWithTsBytes,     
        
414                           null);            
{code}

In the new code,

{code:title=HBaseTimelineWriterImpl.java}
409                     byte[] compoundColumnQualifierBytes =
410                         ApplicationColumnPrefix.EVENT.
411                             getCompoundColQualBytes(eventId, eventTs, null);
{code}

But I think the behavior hasn't changed regarding the last {{null}}. I think in 
both cases the bytes will end with the separator. Could you confirm?

> Support complex filters in TimelineReader
> -----------------------------------------
>
>                 Key: YARN-3863
>                 URL: https://issues.apache.org/jira/browse/YARN-3863
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-3863-YARN-2928.v2.01.patch, 
> YARN-3863-YARN-2928.v2.02.patch, YARN-3863-YARN-2928.v2.03.patch, 
> YARN-3863-feature-YARN-2928.wip.003.patch, 
> YARN-3863-feature-YARN-2928.wip.01.patch, 
> YARN-3863-feature-YARN-2928.wip.02.patch, 
> YARN-3863-feature-YARN-2928.wip.04.patch, 
> YARN-3863-feature-YARN-2928.wip.05.patch
>
>
> Currently filters in timeline reader will return an entity only if all the 
> filter conditions hold true i.e. only AND operation is supported. We can 
> support OR operation for the filters as well. Additionally as primary backend 
> implementation is HBase, we can design our filters in a manner, where they 
> closely resemble HBase Filters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to